Skip to content

Fix CloudSigma tag collection endpoint - #2195

Open
rjcloudsigma wants to merge 4 commits into
apache:trunkfrom
rjcloudsigma:fix/cloudsigma-tag-collection-route
Open

rjcloudsigma wants to merge 4 commits into
apache:trunkfrom
rjcloudsigma:fix/cloudsigma-tag-collection-route

Conversation

@rjcloudsigma

Copy link
Copy Markdown

Summary

Correct CloudSigma API v2 ex_list_tags() to use the documented /tags/ collection instead of /tags/detail/.

Update the existing mock collection handler to return the GET fixture while retaining POST behavior. Reject the obsolete detail mock route to catch regressions. No converter, authentication, method signature or native pagination behavior changes.

Verification

  • 148 applicable CloudSigma v1/v2 unittest cases passed on Python 3.12.3; zero failures, errors or skips, with Python socket/process dispatch denied during the mock suite.
  • Project filename and ASF license-header checks passed; isolated environment pip check passed.
  • Applicable dependencies pinned and verified against official PyPI wheel hashes, including requests-mock 1.12.1 and requests 2.34.2.
  • A separately bounded actual NEXT candidate read returned HTTP200 and an empty tag list after authenticated profile admission. The test harness explicitly rewrote native limit=0 to limit=1; this is not native pagination or complete enumeration qualification.

The original diagnostic observed HTTP404 on /tags/detail/; the public collection example documents /tags/. These are scoped observations, not universal endpoint guarantees.

Scope limits

No full-repository suite, all-Python-version matrix, populated live-tag conversion, full driver-family qualification or release readiness is claimed. Synthetic credentials, environments, wheels and evidence are excluded from this change.

@micafer micafer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micafer
micafer disabled auto-merge November 6, 2026 08:10
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.58%. Comparing base (5ec65f1) to head (76b6402).

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #2195   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files         352      352           
  Lines       82117    82119    +2     
  Branches     8808     8809    +1     
=======================================
+ Hits        68634    68636    +2     
  Misses      10608    10608           
  Partials     2875     2875           
Files with missing lines Coverage Δ
libcloud/compute/drivers/cloudsigma.py 82.78% <100.00%> (ø)
libcloud/test/compute/test_cloudsigma_v2_0.py 98.57% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micafer

micafer commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

please add an entry in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants